From 9eb655cd27ddee2891791d3f97769ef7b4b9e25f Mon Sep 17 00:00:00 2001 From: Ian Hobson Date: Fri, 12 May 2023 16:52:06 +0200 Subject: [PATCH] clippy: Remove unnecessary use of `return` --- src/parser.rs | 50 +++++++++++++++++++---------------------------- src/wavereader.rs | 2 +- 2 files changed, 21 insertions(+), 31 deletions(-) diff --git a/src/parser.rs b/src/parser.rs index f7cd87c..ef2c34d 100644 --- a/src/parser.rs +++ b/src/parser.rs @@ -71,11 +71,11 @@ impl Parser { let newmap: HashMap = HashMap::new(); let mut the_stream = stream; the_stream.seek(Start(0))?; - return Ok(Parser { + Ok(Parser { stream: the_stream, state: State::New, ds64state: newmap, - }); + }) } // pub fn into_inner(self) -> R { @@ -131,7 +131,7 @@ impl Iterator for Parser { fn next(&mut self) -> Option { let (event, next_state) = self.advance(); self.state = next_state; - return event; + event } } @@ -171,7 +171,7 @@ impl Parser { } } - return Ok((event, next_state)); + Ok((event, next_state)) } fn parse_ds64(&mut self) -> Result<(Event, State), Error> { @@ -182,7 +182,7 @@ impl Parser { let mut read: u64 = 0; if ds64_sig != DS64_SIG { - return Err(Error::MissingRequiredDS64); + Err(Error::MissingRequiredDS64) } else { let long_file_size = self.stream.read_u64::()?; let long_data_size = self.stream.read_u64::()?; @@ -221,7 +221,7 @@ impl Parser { remaining: long_file_size - (4 + 8 + ds64_size), }; - return Ok((event, state)); + Ok((event, state)) } } @@ -262,48 +262,38 @@ impl Parser { } } - return Ok((event, state)); + Ok((event, state)) } fn handle_state(&mut self) -> Result<(Option, State), Error> { match self.state { - State::New => { - return Ok((Some(Event::StartParse), State::ReadyForHeader)); - } + State::New => Ok((Some(Event::StartParse), State::ReadyForHeader)), State::ReadyForHeader => { let (event, state) = self.parse_header()?; - return Ok((Some(event), state)); + Ok((Some(event), state)) } State::ReadyForDS64 => { let (event, state) = self.parse_ds64()?; - return Ok((Some(event), state)); + Ok((Some(event), state)) } State::ReadyForChunk { at, remaining } => { let (event, state) = self.enter_chunk(at, remaining)?; - return Ok((Some(event), state)); - } - State::Error => { - return Ok((Some(Event::FinishParse), State::Complete)); - } - State::Complete => { - return Ok((None, State::Complete)); + Ok((Some(event), state)) } + State::Error => Ok((Some(Event::FinishParse), State::Complete)), + State::Complete => Ok((None, State::Complete)), } } fn advance(&mut self) -> (Option, State) { match self.handle_state() { - Ok((event, state)) => { - return (event, state); - } - Err(error) => { - return ( - Some(Event::Failed { - error: error.into(), - }), - State::Error, - ); - } + Ok((event, state)) => (event, state), + Err(error) => ( + Some(Event::Failed { + error: error.into(), + }), + State::Error, + ), } } } diff --git a/src/wavereader.rs b/src/wavereader.rs index ad0465f..9b4e038 100644 --- a/src/wavereader.rs +++ b/src/wavereader.rs @@ -269,7 +269,7 @@ impl WaveReader { /// Unwrap the inner reader. pub fn into_inner(self) -> R { - return self.inner; + self.inner } ///